fabio-rizzo-01 commented on code in PR #2802:
URL: https://github.com/apache/polaris/pull/2802#discussion_r2555055448
##########
api/management-model/src/test/java/org/apache/polaris/core/admin/model/CatalogSerializationTest.java:
##########
@@ -70,6 +71,36 @@ public void testJsonFormat() throws JsonProcessingException {
+ "\"properties\":{\"default-base-location\":\"s3://test/\"},"
+ "\"storageConfigInfo\":{"
+ "\"roleArn\":\"arn:aws:iam::123456789012:role/test-role\","
+ + "\"allowedKmsKeys\":[],"
Review Comment:
The problem is the immutable class that sets them to empty collection by
default , this only happens with collections, and I didn't want to touch those
setting because they might cause a lot more changes.
IMHO i don't think seeing the empty field returned is a massive issue but
I'll leave the judgment to you guys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
