dimas-b commented on code in PR #3145:
URL: https://github.com/apache/polaris/pull/3145#discussion_r2556756673
##########
build-logic/src/main/kotlin/publishing/configurePom.kt:
##########
@@ -58,7 +59,23 @@ internal fun configurePom(project: Project,
mavenPublication: MavenPublication,
val projectNode = asNode()
val parentNode = projectNode.appendNode("parent")
+ // Guarantee that the <parent> element is at a deterministic
location.
+ // This is important for reproducible builds!
+ projectNode.remove(parentNode)
Review Comment:
why append on line 61 and immediately remove here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
