dimas-b commented on code in PR #3170:
URL: https://github.com/apache/polaris/pull/3170#discussion_r2566609565
##########
runtime/service/src/main/java/org/apache/polaris/service/auth/PolarisCredential.java:
##########
@@ -31,14 +31,22 @@
public interface PolarisCredential extends Credential {
static PolarisCredential of(
- @Nullable Long principalId, @Nullable String principalName, Set<String>
principalRoles) {
Review Comment:
Generally speaking, it is preferable to add new builder methods for new
optional parameters (and chain old methods into them). This way existing code
that does not use new optional parameter won't have to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
