ajantha-bhat commented on PR #36:
URL: https://github.com/apache/polaris-tools/pull/36#issuecomment-3585563754

   Thanks @jbonofre for the fixes. 
   
   TIL that 
   
   - https://github.com/jk1/Gradle-License-Report doesn't include all 
transitive dependencies and we need to do identify depdnencies manually and 
include them for license.
   - Notice need to included if the dependency is ASF License and notice is 
relavent (if it just mentions project developed under ASF, no need to include 
that in notice).
   - Don't specify version in the License.
   
   We don't have a standard way for all apache project I guess. We should 
discuss this in ASF board meeting next time and come up with a standard apache 
project that automatically generates License and Notice. 
   
   @snazy: Could you please take another look and approve the PR if it is ok? 
JB cannot self approve this as he has a commit in this PR.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to