cccs-cat001 commented on code in PR #3170:
URL: https://github.com/apache/polaris/pull/3170#discussion_r2572301802
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisPrincipal.java:
##########
@@ -74,4 +106,8 @@ static PolarisPrincipal of(String name, Map<String, String>
properties, Set<Stri
* as permissions, preferences, or other metadata.
*/
Map<String, String> getProperties();
+
+ /** Returns the access token of the current user. */
+ @Nullable
+ String getToken();
Review Comment:
Seems the same to me, what's bad about using `@Nullable`?
##########
site/content/in-dev/unreleased/command-line-interface.md:
##########
@@ -151,6 +151,7 @@ options:
--role-arn (Only for AWS S3) A role ARN to use when connecting to S3
--region (Only for S3) The region to use when connecting to S3
--external-id (Only for S3) The external ID to use when connecting to S3
+ --propagate-api-user-identity (Only for S3) Whether to use the
requesting users identity when connecting to the STS
Review Comment:
sure does! my bad :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
