MonkeyCanCode commented on code in PR #85: URL: https://github.com/apache/polaris-tools/pull/85#discussion_r2575444138
########## console/Dockerfile: ########## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Build stage +FROM node:20-alpine AS builder Review Comment: Does it makes sense to use UBI images as well here as that is what we are using for polaris images. In this case, we will be looking at the following: 1. node: https://catalog.redhat.com/en/software/containers/ubi9/nodejs-20-minimal/64770ddd0e699534bb564b3b 2. nginx: https://catalog.redhat.com/en/software/containers/ubi9/nginx-126/678f5851a09b9e2d461ba1d9 ########## console/src/api/auth.ts: ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import axios from "axios" +import { apiClient } from "./client" +import { navigate } from "@/lib/navigation" +import { REALM_HEADER_NAME } from "@/lib/constants" +import type { OAuthTokenResponse } from "@/types/api" + +// Always use relative URL to go through the proxy (dev server or production server) +// This avoids CORS issues by proxying requests through the server +// The server.ts proxy handles /api routes in production, and Vite handles them in development +const TOKEN_URL = "/api/catalog/v1/oauth/tokens" + +// Log OAuth URL in development only +if (import.meta.env.DEV) { + console.log("🔐 Using OAuth token URL:", TOKEN_URL) +} + +export const authApi = { + getToken: async ( + clientId: string, + clientSecret: string, + realm?: string + ): Promise<OAuthTokenResponse> => { + const formData = new URLSearchParams() + formData.append("grant_type", "client_credentials") Review Comment: I would suggest the same for `grant_type` as what @flyrain points out. There are 2 allowed values for it: https://github.com/apache/polaris/blob/ab421e0f1330d1c95eb9a4f07f9bfab10c7f7e2e/runtime/service/src/main/java/org/apache/polaris/service/auth/internal/broker/TokenRequestValidator.java#L32 ########## console/src/api/catalog/namespaces.ts: ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { apiClient } from "../client" +import type { + Namespace, + ListNamespacesResponse, + CreateNamespaceRequest, +} from "@/types/api" + +/** + * Encodes a namespace array to URL format. + * Namespace parts are separated by the unit separator character (0x1F). + */ +function encodeNamespace(namespace: string[]): string { + return namespace.join("\x1F") +} + + +export const namespacesApi = { + /** + * List namespaces for a catalog, optionally filtering by parent namespace. + * @param prefix - The catalog name (prefix) + * @param parent - Optional parent namespace array (e.g., ["accounting", "tax"]) + */ + list: async ( + prefix: string, + parent?: string[] + ): Promise<Namespace[]> => { + const params: Record<string, string> = {} + if (parent && parent.length > 0) { + params.parent = encodeNamespace(parent) + } + + const response = await apiClient Review Comment: NIT: should we consider for adding support for `pageSize` as if an user create high number of namespace, the UI loading will taking extremely long of time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
