MonkeyCanCode commented on PR #84: URL: https://github.com/apache/polaris-tools/pull/84#issuecomment-3604924436
> Thanks a lot for working on it, @MonkeyCanCode. It is a great tool for integration test. Can we move `client.py` out of `mcp-server/` so it’s clear that this is an integration-test helper rather than production code. > > Right now it lives alongside the runtime server modules, which means, it becomes part of the package namespace, it will get shipped with the PyPI artifact, and it can confuse contributors into thinking it’s a supported API. > > A cleaner structure would be creating a dedicated **integration test** directory: > > ``` > mcp-server/ > polaris_mcp/ # production code > tests/ # unit tests > int_test/ # <-- new directory for manual/integration tools > client.py > it.py # move all sample commands in README here > ``` > > Then the README examples would simply reference: > > ``` > uv run int_test/it.py > ``` > > WDYT? Hello @flyrain , Thanks for the review. So `client.py` was under `mcp_server` but on the same dir level as `polaris_mcp`. Looking at `pyprojet.toml`, it shouldn't be include in the package: ``` [tool.setuptools.packages.find] include = ["polaris_mcp"] ``` But yes, I do agreed with you it may be better to put under some common path in case if we are planning to add more integration/manual testing tools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
