flyrain commented on code in PR #3194:
URL: https://github.com/apache/polaris/pull/3194#discussion_r2586302924


##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -46,6 +46,7 @@ dependencies {
   // TODO: extract a polaris-rest module as a thin layer for
   //  client to depends on.
   implementation(project(":polaris-core")) { isTransitive = false }
+  
testImplementation("org.apache.hudi:hudi-spark3.5-bundle_${scalaVersion}:1.1.0")

Review Comment:
   Nit: we put version in the file `pluginlibs.versions.toml`, refer it as line 
35 does. 



##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -46,6 +46,7 @@ dependencies {
   // TODO: extract a polaris-rest module as a thin layer for
   //  client to depends on.
   implementation(project(":polaris-core")) { isTransitive = false }
+  
testImplementation("org.apache.hudi:hudi-spark3.5-bundle_${scalaVersion}:1.1.0")

Review Comment:
   Nit: we put versions in the file `pluginlibs.versions.toml`, refer it as 
line 35 does. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to