flyrain commented on code in PR #83:
URL: https://github.com/apache/polaris-tools/pull/83#discussion_r2586377247
##########
mcp-server/polaris_mcp/tools/catalog.py:
##########
@@ -106,6 +106,10 @@ def call(self, arguments: Any) -> ToolExecutionResult:
copy_if_object(arguments.get("query"), delegate_args, "query")
copy_if_object(arguments.get("headers"), delegate_args, "headers")
+ realm = arguments.get("realm")
+ if isinstance(realm, str) and realm.strip():
+ delegate_args["realm"] = realm
Review Comment:
Sorry, I may not have expressed myself clearly earlier. Let me restate it:
if the realm config is missing, it should absolutely fall back to the non-realm
setting. However, if a user explicitly configures a realm but that realm is
invalid or not configured, we should fail fast rather than silently falling
back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
