singhpk234 commented on code in PR #3228:
URL: https://github.com/apache/polaris/pull/3228#discussion_r2596645544
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizer.java:
##########
@@ -28,6 +28,12 @@
/** Interface for invoking authorization checks. */
public interface PolarisAuthorizer {
+ boolean requiresPrincipalRoles();
+
+ boolean requiresCatalogRoles();
+
+ boolean requiresResolvedEntities();
Review Comment:
can we have public docs for this ?
Also to avoid breaking down stream service can we have default values as
true ? downstream impl of this interface can override it
##########
extensions/auth/opa/impl/src/main/java/org/apache/polaris/extension/auth/opa/OpaPolarisAuthorizer.java:
##########
@@ -95,6 +95,21 @@ public OpaPolarisAuthorizer(
this.objectMapper = objectMapper;
}
+ @Override
+ public boolean requiresPrincipalRoles() {
+ return false;
+ }
+
+ @Override
+ public boolean requiresCatalogRoles() {
+ return false;
+ }
+
+ @Override
+ public boolean requiresResolvedEntities() {
+ return false;
+ }
Review Comment:
I wonder this comes under the use case Delegated AuthZ, should we have
another interface for it entirely to undertand whats required for delegation ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
