adnanhemani commented on PR #3217: URL: https://github.com/apache/polaris/pull/3217#issuecomment-3630037606
Took a quick look, this looks great @adam-christian-software! I think we are good to unblock #2962 - I will make a comment on there and look for another review. Agreed on most points that @adutra said above. A few questions/followups: * Regarding redactions in strings: Aren't we transforming all POJOs into strings for the matter of this transformation? In that case, isn't a string okay? * Regarding configurable redaction rules: This would be interesting indeed - but how would some user do this? They would have to write new Java code and re-compile Polaris for this? Or were you thinking of something else? * Agreed on the flattening making this all easier. Do we know if @olsoloviov is working on it, as per the last email on the ML thread? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
