binarycat0 commented on code in PR #114:
URL: https://github.com/apache/polaris-tools/pull/114#discussion_r2650739290
##########
console/src/api/client.ts:
##########
@@ -23,7 +23,7 @@ import { REALM_HEADER_NAME } from "@/lib/constants"
// Always use relative URLs to go through the proxy (dev server or production
server)
// This avoids CORS issues by proxying requests through the server
-// The server.ts proxy handles /api routes in production, and Vite handles
them in development
+// The server. ts proxy handles /api routes in production, and Vite handles
them in development
Review Comment:
These redundant changes look like the typos or came from some linter. Check
your linter/ide settings.
##########
console/src/api/client.ts:
##########
@@ -12,7 +12,7 @@
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
+ * KIND, either express or implied. See the License for the
Review Comment:
AFAIK, License disclaimers generated automatically and not recommended being
changed manually. Better to revert change.
##########
console/src/api/client.ts:
##########
@@ -33,6 +33,8 @@ class ApiClient {
private managementClient: AxiosInstance
private catalogClient: AxiosInstance
private polarisClient: AxiosInstance
+ // Store access token in memory only (not in localStorage for security)
Review Comment:
NIT: We could probably remove this comment since the code is already
self-explanatory.
##########
console/src/hooks/useAuth.tsx:
##########
@@ -77,5 +68,4 @@ export function useAuth() {
throw new Error("useAuth must be used within an AuthProvider")
}
return context
-}
-
+}
Review Comment:
NIT: Let’s avoid extra whitespace-only changes and keep this PR focused on
functional updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
