MonkeyCanCode commented on PR #3410:
URL: https://github.com/apache/polaris/pull/3410#issuecomment-3736631953

   > Overall LGTM! Thanks for migrating this! I believe this could also make 
the release process easier in the future.
   > 
   > One thing I noticed was that the spark getting-started example now miss 
the ipynb in jupyter lab:
   > 
   > <img alt="Image" width="292" height="338" 
src="https://private-user-images.githubusercontent.com/140284484/534299274-f29038ef-2d71-43c1-926c-103a1f5e6e9f.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjgxODI1NjMsIm5iZiI6MTc2ODE4MjI2MywicGF0aCI6Ii8xNDAyODQ0ODQvNTM0Mjk5Mjc0LWYyOTAzOGVmLTJkNzEtNDNjMS05MjZjLTEwM2ExZjVlNmU5Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMTEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDExMlQwMTQ0MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNjI4ZTliNDNiODc5NDFlNzE0YzA3YjJmZGE0MTE5NDY3Yjk4MDQzMjRjMmFlY2U1ZDBkYTEwODIxNzE0OWFhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.SLOwuAPIQGfsFZxYMH3igZoXI1BwPij3bfspxuenb9Q";>
   > But this may not be relevant to this PR.
   
   So this may be due to change of base image that I done long time back where 
`ipynb` is not part of `jupyterlab` library. But do we need this dependency as 
the current getting started notebook is fully functional.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to