dimas-b commented on code in PR #3414:
URL: https://github.com/apache/polaris/pull/3414#discussion_r2682755975
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/StorageAccessConfigProvider.java:
##########
@@ -187,6 +189,24 @@ private CredentialVendingContext
buildCredentialVendingContext(
builder.activatedRoles(Optional.of(rolesString));
}
+ // Extract OpenTelemetry trace ID for end-to-end correlation
+ // This enables correlation between credential vending (CloudTrail),
catalog operations
+ // (Polaris events), and metrics reports from compute engines
+ builder.traceId(getCurrentTraceId());
Review Comment:
Since `CredentialVendingContext` is part of the credentials cache, adding
trace ID will make the cache ineffective (100% misses), if I understand
correctly.
While this use case may be meaningful in some environments, it may lead to
undesirable behaviour in others.
I propose to cover this with a separate feature flag in this PR (to allow
using STS tags without trace IDs). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
