flyrain opened a new pull request, #3433: URL: https://github.com/apache/polaris/pull/3433
The old implementation silently dropped fractional token accrual. That means any rate below 1000 tokens/sec could never refill the bucket: each call adds <1 token, cast to long becomes 0, so tokens stay at 0 forever. Switching to double preserves fractional accumulation so the bucket refills correctly over time. ## Checklist - [x] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [x] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
