obelix74 commented on PR #3385: URL: https://github.com/apache/polaris/pull/3385#issuecomment-3761966985
@dimas-b thanks for the help in merging https://github.com/apache/polaris/pull/3414. I have rebased this PR against `main` - looks like the event code was simplified and rewritten. I have redone the event code to follow the changes. I think this PR can be split into two. PR 1: Enable metrics event emission • EventAttributes.java - add REPORT_METRICS_REQUEST attribute • IcebergRestCatalogEventServiceDelegator.java - emit BEFORE/AFTER events in reportMetrics() PR 2: Add metrics persistence (depends on PR 1) • PolarisPersistenceEventListener.java - handle AFTER_REPORT_METRICS, extract ScanReport/CommitReport data • PolarisPersistenceEventListenerTest.java - new test file for persistence listener If this helps, please let me know and I can split this PR into two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
