adutra commented on code in PR #3250:
URL: https://github.com/apache/polaris/pull/3250#discussion_r2705766688


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/Resolver.java:
##########
@@ -764,6 +794,17 @@ private ResolverStatus 
resolveCallerPrincipalAndPrincipalRoles(
     return new ResolverStatus(ResolverStatus.StatusEnum.SUCCESS);
   }
 
+  private boolean isExternalPrincipal() {
+    return 
Boolean.parseBoolean(polarisPrincipal.getProperties().getOrDefault("external", 
"false"));

Review Comment:
   Same remark: maybe we should expose a `getType` method in `PolarisPrincipal` 
that returns `PolarisPrincipalType`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to