dimas-b commented on code in PR #3456: URL: https://github.com/apache/polaris/pull/3456#discussion_r2709448304
########## runtime/service/src/main/java/org/apache/polaris/service/events/AttributeMap.java: ########## @@ -18,11 +18,13 @@ */ package org.apache.polaris.service.events; +import jakarta.enterprise.context.RequestScoped; import java.util.HashMap; import java.util.Map; import java.util.Optional; /** A type-safe container for event attributes. This class is mutable and not thread-safe! */ +@RequestScoped Review Comment: The nature of this class is to accumulate attributes as the request is processed (potentially by many threads). In light of that, from my POV it is preferable to make it thread-safe (which is not a huge task in this particular case, I hope). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
