obelix74 commented on code in PR #3468:
URL: https://github.com/apache/polaris/pull/3468#discussion_r2710004399
##########
runtime/service/src/main/java/org/apache/polaris/service/reporting/PolarisMetricsReporter.java:
##########
@@ -18,9 +18,40 @@
*/
package org.apache.polaris.service.reporting;
+import java.time.Instant;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.metrics.MetricsReport;
+/**
+ * SPI interface for reporting Iceberg metrics received by Polaris.
+ *
+ * <p>Implementations can be used to send metrics to external systems for
analysis and monitoring.
+ * Custom implementations must be annotated with {@link
Review Comment:
Reworded the JavaDoc, please see if it makes sense.
##########
runtime/service/src/testFixtures/java/org/apache/polaris/service/events/listeners/TestPolarisEventListener.java:
##########
@@ -43,4 +43,17 @@ public PolarisEvent getLatest(PolarisEventType type) {
}
return latest;
}
+
+ /**
+ * Returns the latest event of the specified type, or null if no such event
has been recorded.
+ * This is useful for tests that need to verify no event was emitted.
+ */
+ public PolarisEvent getLatestOrNull(PolarisEventType type) {
Review Comment:
Removed unused methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
