RussellSpitzer commented on code in PR #3396: URL: https://github.com/apache/polaris/pull/3396#discussion_r2722130152
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -128,16 +130,29 @@ polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"] # realm overrides # polaris.features.realm-overrides."my-realm"."SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION"=true -# polaris.persistence.type=in-memory-atomic +# Available types: +# - in-memory - InMemoryPolarisMetaStoreManagerFactory +# - in-memory-atomic - InMemoryAtomicOperationMetaStoreManagerFactory +# - nosql (beta) - NoSQL persistence backend, define the backend type via 'polaris.persistence.nosql.backend' +# - relational-jdbc polaris.persistence.type=in-memory -# polaris.persistence.type=relational-jdbc +# Database backend for 'nosql' persistence-type +# Available backends: +# - InMemory - for testing purposes +# - MongoDb - configure the via the Quarkus extension +# Configure the necessary MongoDB properties starting with 'quarkus.mongodb.' in this file. +# See https://quarkus.io/guides/mongodb#configuration-reference for details about these configurations. +#polaris.persistence.nosql.backend=InMemory Review Comment: nit: whitespace ########## runtime/defaults/src/main/resources/application.properties: ########## @@ -128,16 +130,29 @@ polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"] # realm overrides # polaris.features.realm-overrides."my-realm"."SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION"=true -# polaris.persistence.type=in-memory-atomic +# Available types: +# - in-memory - InMemoryPolarisMetaStoreManagerFactory +# - in-memory-atomic - InMemoryAtomicOperationMetaStoreManagerFactory +# - nosql (beta) - NoSQL persistence backend, define the backend type via 'polaris.persistence.nosql.backend' +# - relational-jdbc polaris.persistence.type=in-memory -# polaris.persistence.type=relational-jdbc +# Database backend for 'nosql' persistence-type +# Available backends: +# - InMemory - for testing purposes +# - MongoDb - configure the via the Quarkus extension +# Configure the necessary MongoDB properties starting with 'quarkus.mongodb.' in this file. +# See https://quarkus.io/guides/mongodb#configuration-reference for details about these configurations. +#polaris.persistence.nosql.backend=InMemory polaris.secrets-manager.type=in-memory # if set to true it will try to start localstack at build and run time for the local environment # https://docs.quarkiverse.io/quarkus-amazon-services/dev/amazon-rds.html#_configuration_reference for more details quarkus.rds.devservices.enabled=false quarkus.rds.sync-client.type=apache +## MongoDB specific configuration +#quarkus.mongodb.database=polaris Review Comment: nit: whitespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
