flyrain commented on PR #3513: URL: https://github.com/apache/polaris/pull/3513#issuecomment-3797894222
I think @singhpk234 has a good point. Given the size of this change, around 5600 LOC(79 new files), I think it is worth pausing and discussing this on the dev mailing list. Reusing an existing, well maintained library where possible is generally preferable, and we should be careful about reinventing the wheel unless there is a clear technical gap that existing solutions cannot cover. It would be good to have a broader discussion on dev ML about: • what concrete requirements are not met by existing libraries like `S3Mock` • whether those gaps are fundamental or could be addressed with extension or configuration • the long term maintenance cost of carrying a large custom test stack in Polaris If we agree that custom code is still the right direction after that discussion, at least we will have alignment and a documented rationale. Happy to help start a dev list thread if that sounds reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
