adutra commented on code in PR #3554:
URL: https://github.com/apache/polaris/pull/3554#discussion_r2731611608
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventType.java:
##########
@@ -145,8 +145,8 @@ public enum PolarisEventType {
AFTER_RENAME_VIEW,
BEFORE_REPLACE_VIEW,
AFTER_REPLACE_VIEW,
- BEFORE_COMMIT_VIEW,
- AFTER_COMMIT_VIEW,
+ BEFORE_COMMIT_VIEW, // REMOVED FROM SOURCE CODE
Review Comment:
I'm catching up here and saw this related conversation:
https://github.com/apache/polaris/pull/3195/changes#r2593440033
I'm not sure I agree with keeping these constants. Granted the ordinals will
change if we remove them. But the feature is in beta status right now. It feels
odd to see deprecated/unused constants in an API that is not even "official"
yet.
@adnanhemani @dimas-b what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
