yushesp commented on code in PR #3525:
URL: https://github.com/apache/polaris/pull/3525#discussion_r2733316056
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -103,17 +103,15 @@ public StorageAccessConfig getSubscopedCreds(
String roleSessionName =
includePrincipalNameInSubscopedCredential
- ? "polaris-" + polarisPrincipal.getName()
+ ? AwsRoleSessionNameSanitizer.sanitize("polaris-" +
polarisPrincipal.getName())
Review Comment:
@dimas-b We do need to inject the principal name into the session name. We
enabled the feature flag and ran into an error because my principal name had a
special character.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
