dimas-b opened a new pull request, #3573: URL: https://github.com/apache/polaris/pull/3573
The existing `PolarisConfigurationStore` interface is a fixture of SPI methods providing config values from the environment and utility methods for various lookup parameter permutations and type casts. This change adds `RealmConfigurationSource` for the SPI part and moves lookup logic into `RealmConfigImpl`. Note that existing service code always accesses config via `RealmConfig`. The old `PolarisConfigurationStore` interface remain for backward compatibility and but redirects actual config lookup to `RealmConfigImpl`. <!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
