dimas-b commented on code in PR #3520:
URL: https://github.com/apache/polaris/pull/3520#discussion_r2737472611


##########
.github/workflows/site.yml:
##########
@@ -23,15 +23,33 @@ on:
     branches: [ "main" ]
   pull_request:
     branches: [ "main" ]
+  workflow_call:
+    # The workflow is programmatically "protected" to be only callable from 
the 'apache/polaris' repo.
+    # Beware: this workflow will be called with with the `github` context from 
the 'versioned-docs' branch,

Review Comment:
   ```suggestion
       # Beware: this workflow will be called with the `github` context from 
the 'versioned-docs' branch,
   ```



##########
.github/workflows/site.yml:
##########
@@ -23,15 +23,33 @@ on:
     branches: [ "main" ]
   pull_request:
     branches: [ "main" ]
+  workflow_call:
+    # The workflow is programmatically "protected" to be only callable from 
the 'apache/polaris' repo.
+    # Beware: this workflow will be called with with the `github` context from 
the 'versioned-docs' branch,
+    # which means, for example, that the `github.ref` would be 
'refs/heads/versioned-docs'.
+
+# Ensure that no two site publications happen concurrently.
+# 1 job per reference can run concurrently, no cancellation
+concurrency:
+  group: ${{ github.ref }}

Review Comment:
   So, `github.ref` could be `refs/heads/versioned-docs` (when called 
programmatically) or `main`... and those jobs can still run concurrently? Is 
that expected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to