fivetran-ashokborra commented on code in PR #3566:
URL: https://github.com/apache/polaris/pull/3566#discussion_r2737507301


##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatasourceOperations.java:
##########
@@ -312,7 +312,8 @@ private boolean isRetryable(SQLException e) {
 
     // Additionally, one might check for specific error messages or other 
conditions
     return e.getMessage().toLowerCase(Locale.ROOT).contains("connection 
refused")
-        || e.getMessage().toLowerCase(Locale.ROOT).contains("connection 
reset");
+        || e.getMessage().toLowerCase(Locale.ROOT).contains("connection reset")
+        || e.getMessage().toLowerCase(Locale.ROOT).contains("acquisition 
timeout");

Review Comment:
   Let me see if there are any additional traces
   ```
   Caused by: java.sql.SQLException: Failed due to 'Acquisition timeout while 
waiting for new connection' (error code 0, sql-state 'null'), after 1 attempts 
and 5000 milliseconds
        at 
org.apache.polaris.persistence.relational.jdbc.DatasourceOperations.withRetries(DatasourceOperations.java:300)
        at 
org.apache.polaris.persistence.relational.jdbc.DatasourceOperations.executeSelectOverStream(DatasourceOperations.java:153)
        at 
org.apache.polaris.persistence.relational.jdbc.DatasourceOperations.executeSelect(DatasourceOperations.java:134)
        at 
org.apache.polaris.persistence.relational.jdbc.JdbcBasePersistenceImpl.lookupEntities(JdbcBasePersistenceImpl.java:399)
        ... 64 more
   Caused by: java.sql.SQLException: Acquisition timeout while waiting for new 
connection
        at 
io.agroal.pool.ConnectionPool.handlerFromSharedCache(ConnectionPool.java:367)
        at io.agroal.pool.ConnectionPool.getConnection(ConnectionPool.java:293)
        at io.agroal.pool.DataSource.getConnection(DataSource.java:86)
        at 
io.agroal.api.AgroalDataSource_sqqLi56D50iCdXmOjyjPSAxbLu0_Synthetic_ClientProxy.getConnection(Unknown
 Source)
        at 
org.apache.polaris.persistence.relational.jdbc.DatasourceOperations.borrowConnection(DatasourceOperations.java:339)
        at 
org.apache.polaris.persistence.relational.jdbc.DatasourceOperations.lambda$executeSelectOverStream$2(DatasourceOperations.java:156)
        at 
org.apache.polaris.persistence.relational.jdbc.DatasourceOperations.withRetries(DatasourceOperations.java:271)
        ... 67 more
   Caused by: java.util.concurrent.TimeoutException
        at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:204)
        at 
io.agroal.pool.ConnectionPool.handlerFromSharedCache(ConnectionPool.java:344)
        ... 73 more
   
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to