evindj opened a new pull request, #3608:
URL: https://github.com/apache/polaris/pull/3608

   This PR is a continuation of https://github.com/apache/polaris/issues/3418 
where we agreed we should remove associate enums values from Enum definition. 
   The code also adds a constructor to help not having to rely on ordinals() to 
to have enum codes.
   
   I incremented enum code assignments by 100 based on categories. I am happy 
to take feedback here.
   
   Does not change logic and removes only enums that are no longer used so 
behavior does not change.
   
   ./gradlew clean assemble -x test
   
   Is successful.
   
   ## Checklist
   - [ ] ๐Ÿ›ก๏ธ Don't disclose security issues! (contact [email protected])
   - [ ] ๐Ÿ”— Clearly explained why the changes are needed, or linked related 
issues: Fixes #
   - [ ] ๐Ÿงช Added/updated tests with good coverage, or manually tested (and 
explained how)
   - [ ] ๐Ÿ’ก Added comments for complex logic
   - [ ] ๐Ÿงพ Updated `CHANGELOG.md` (if needed)
   - [ ] ๐Ÿ“š Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to