MonkeyCanCode commented on code in PR #3612:
URL: https://github.com/apache/polaris/pull/3612#discussion_r2742954171
##########
getting-started/ceph/docker-compose.yml:
##########
@@ -148,10 +148,10 @@ services:
command:
- "-c"
- >-
- echo Creating Ceph bucket...;
- aws s3 mb s3://${S3_POLARIS_BUCKET};
- aws s3 ls;
- echo Bucket setup complete.;
+ echo Creating Ceph bucket... &&
+ aws s3 mb s3://${S3_POLARIS_BUCKET} &&
+ aws s3 ls &&
+ echo Bucket setup complete.
Review Comment:
This will return 0 as well no?
##########
getting-started/keycloak/docker-compose.yml:
##########
@@ -71,12 +71,12 @@ services:
command:
- "-c"
- >-
- apk add --no-cache jq &&
- chmod +x /polaris/create-catalog.sh &&
+ apk add --no-cache jq &&
token=$$(curl
http://keycloak:8080/realms/iceberg/protocol/openid-connect/token --user
client1:s3cr3t -d 'grant_type=client_credentials' | jq -r .access_token) &&
/polaris/create-catalog.sh realm-internal &&
/polaris/create-catalog.sh realm-external $$token &&
- /polaris/create-catalog.sh realm-mixed $$token
+ /polaris/create-catalog.sh realm-mixed $$token &&
+ sleep 120
Review Comment:
So yeah, while I was doing a local prototyping, I ran into this issue as
well where `--exit-code-from` is not happy with this. What I ended up doing is
to use `tail /dev/null` to keep the service up then use health check on service
ready instead of completed. Sleep 120 here will work but if for whatever reason
these bash scripts took more than 120s (assuming they get very complex later
on), this will bite us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
