singhpk234 commented on code in PR #3619:
URL: https://github.com/apache/polaris/pull/3619#discussion_r2751796558
##########
polaris-core/src/test/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfoTest.java:
##########
@@ -148,6 +154,15 @@ public void testRoleArnParsing() {
AwsStorageConfigurationInfo::getRoleARN,
AwsStorageConfigurationInfo::getAwsAccountId,
AwsStorageConfigurationInfo::getAwsPartition)
- .containsExactly("arn:aws:iam::012345678901:role/jdoe",
"012345678901", "aws");
+ .containsExactly(roleArn, expectedAccountId, expectedPartition);
+ }
+
+ static Stream<Arguments> testRoleArnParsing() {
+ return Stream.of(
+ Arguments.of("arn:aws:iam::012345678901:role/jdoe", "012345678901",
"aws"),
+ Arguments.of("arn:aws-us-gov:iam::012345678901:role/jdoe",
"012345678901", "aws-us-gov"),
+ Arguments.of("arn:aws-cn:iam::012345678901:role/jdoe", "012345678901",
"aws-cn"),
+
Arguments.of("urn:ecs:sts::s3:assumed-role/s3assumeRole/user1-105-temp", "s3",
"ecs"),
Review Comment:
I didn't fully understand this example, expected account id is `s3` ? can
you please elaborate and add a code comment
##########
CHANGELOG.md:
##########
@@ -68,6 +68,8 @@ request adding CHANGELOG notes for breaking (!) changes and
possibly other secti
### Fixes
+- Enable non-AWS STS role ARNs
Review Comment:
minor : worth mentioning ECS as an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
