adutra commented on PR #3658:
URL: https://github.com/apache/polaris/pull/3658#issuecomment-3843069516
Heads up: this change *may* have implications for the following cloud tests:
* `RestCatalogS3IT`
* `RestCatalogGcsIT`
* `RestCatalogAdlsIT`
* `RestCatalogAdlsCredentialVendingIT`
However I cannot test them 🤷♂️
The first 3 seem are probably fine: credential vending is implicitly
enabled, but the clients don't request any access delegation mode by default.
This should work as long as the `RESTCatalog` clients have access to their own
storage credentials via the environment (which seems to be the intent).
The last one, `RestCatalogAdlsCredentialVendingIT`, _explicitly_ enables
credentials vending, but in fact, behaves exactly like `RestCatalogAdlsIT`,
i.e., the `RESTCatalog` clients are not configured to request any delegation
mode. Imho this test is lacking the annotation:
```java
@RestCatalogConfig({"header.X-Iceberg-Access-Delegation",
"vended-credentials"})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
