[ 
https://issues.apache.org/jira/browse/RATIS-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294636#comment-17294636
 ] 

Tsz-wo Sze commented on RATIS-1312:
-----------------------------------

> ...  we should not check whether we have receive all packets by checking 
> h.getDataLength() + headerBufLen <= buf.readableBytes()  ...

[~yjxxtd], that's a good point -- our packet format (header, body) is not good 
for netty.  We should change it to (length, header, body).  Then, it doesn't 
have to decode the protobuf header when reading the body.  It can use the 
length to determine if the entire message is received.  (now, it has to decode 
the protobuf header for every packet when reading the body, and then reject it.)

> Compare the performance between HDFS and DataStreamApi
> ------------------------------------------------------
>
>                 Key: RATIS-1312
>                 URL: https://issues.apache.org/jira/browse/RATIS-1312
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: runzhiwang
>            Priority: Major
>         Attachments: hdfs.svg, streaming.svg
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to