szetszwo commented on a change in pull request #506:
URL: https://github.com/apache/ratis/pull/506#discussion_r750772550
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/raftlog/RaftLogBase.java
##########
@@ -394,6 +396,9 @@ public LogEntryProto getEntry(TimeDuration timeout) throws
RaftLogIOException, T
} catch (TimeoutException t) {
final String err = getName() + ": Timeout readStateMachineData for " +
toLogEntryString(logEntry);
LOG.error(err, t);
Review comment:
I forgot to mention last time -- let's move LOG.error inside the
if-statement, i.e.
```
if (timeout.compareTo(readStatemachineTimeout) > 0) {
getRaftLogMetrics().onStateMachineReadTimeout();
final String err = getName() + ": Timeout readStateMachineData
for " + toLogEntryString(logEntry);
LOG.error(err, t);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
