adoroszlai commented on a change in pull request #1:
URL:
https://github.com/apache/ratis-hadoop-projects/pull/1#discussion_r796666652
##########
File path: pom.xml
##########
@@ -69,25 +69,10 @@
</licenses>
<modules>
- <module>ratis-docs</module>
<module>ratis-proto</module>
Review comment:
Maybe `ratis-proto` can be deleted after moving `Hadoop.proto` to
`ratis-hadoop` module? It needs some tweaks in `ratis-hadoop/pom.xml`, too.
##########
File path: .github/workflows/post-commit.yml
##########
@@ -83,8 +83,8 @@ jobs:
strategy:
matrix:
profile:
- - grpc
- - server
+ - hadooprpc
+ - logservice
- misc
Review comment:
Tests in `ratis-hadoop` are disabled and currently there are no "misc"
tests. So I think we might as well remove the matrix, and run all tests in a
single check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
