szetszwo commented on a change in pull request #616:
URL: https://github.com/apache/ratis/pull/616#discussion_r819251195
##########
File path:
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -348,15 +348,14 @@ static void setForceSyncNum(RaftProperties properties,
int forceSyncNum) {
setInt(properties::setInt, FORCE_SYNC_NUM_KEY, forceSyncNum);
}
-
- String FLUSH_INTERVAL_MIN_KEY = PREFIX + ".flush.interval.min";
- TimeDuration FLUSH_INTERVAL_MIN_DEFAULT = TimeDuration.ZERO;
- static TimeDuration flushIntervalMin(RaftProperties properties) {
- return
getTimeDuration(properties.getTimeDuration(FLUSH_INTERVAL_MIN_DEFAULT.getUnit()),
- FLUSH_INTERVAL_MIN_KEY, FLUSH_INTERVAL_MIN_DEFAULT,
getDefaultLog());
+ String ASYNC_FLUSH_ENABLED_KEY = PREFIX + ".async.flush.enabled";
Review comment:
@SincereXIA , if the performance can be improved by async, let's just
change the code to async and don't need this conf.
I guess you are testing the change. Will wait for your results. Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
