adoroszlai commented on PR #691: URL: https://github.com/apache/ratis/pull/691#issuecomment-1192332989
> > There is a difference between a configuration that has explicit custom settings for client/admin ports, and one that has no setting and falls back to the server port value. > > Emm, it keeps the same logic as before, it seems not a problem. Or, maybe I don't get your points. I didn't mean the patch breaks anything. Consider two different configurations: ``` raft.grpc.server.port=12345 ``` and ``` raft.grpc.admin.port=12345 raft.grpc.client.port=12345 raft.grpc.server.port=12345 ``` Ratis works the same way with both due to the fallback logic. Prior to the patch they were logged differently (`-1 (default)` for admin/client in the first case, `12345 (custom)` in the second case), but with the patch they both result in the same log output. Now assume we only change `raft.grpc.server.port` to a different value in both cases. Ratis behavior is different for these two configurations (regardless of the patch), since the first one uses the new port as fallback, while the second one has explicit custom config for admin/client ports. My point is that this difference in log messages may be useful in some cases. (E.g. if someone else is making the config change and you only see the logs.) But the new log content is probably better in most cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
