szetszwo commented on PR #699: URL: https://github.com/apache/ratis/pull/699#issuecomment-1205503642
> ... the current updateIncreasingly is less strict than updateToMax. updateToMax will atomically check if the new value is greater than the old value before update the index while updateIncreasingly doesn the check after the value change in a way which has no atomic guarantee. Yes, updateIncreasingly does the check after the value change and it will throw an exception if the check failed. The check is an assertion in order to make sure that the condition always holds. If it fails, it is a bug in the code. Since updateIncreasingly only allows the new value >= the old value while updateToMax allows any value, we say updateIncreasingly more strict than updateToMax in this sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
