szetszwo commented on code in PR #712:
URL: https://github.com/apache/ratis/pull/712#discussion_r945209289
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java:
##########
@@ -204,6 +207,11 @@ public boolean shouldSendAppendEntries() {
return appendLogRequestObserver == null || super.shouldSendAppendEntries();
}
+ @Override
+ public void sendAppendEntriesNow() throws IOException {
+ sendAppendEntries(true);
Review Comment:
Only run() should send appendEntries. Otherwise, there are synchronization
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
