AngersZhuuuu commented on code in PR #834:
URL: https://github.com/apache/ratis/pull/834#discussion_r1122535641
##########
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##########
@@ -65,6 +65,10 @@ public static RaftPeerId getPeerId(String host, int port) {
*/
public static RaftClient createClient(RaftGroup raftGroup) {
RaftProperties properties = new RaftProperties();
+ // Since ratis-shell support GENERIC_COMMAND_OPTIONS, here we should
+ // set these options to raft properties to make it work.
+ System.getProperties().stringPropertyNames().forEach(
+ key -> properties.setIfUnset(key, System.getProperty(key)));
RaftClientConfigKeys.Rpc.setRequestTimeout(properties,
Review Comment:
> We should check if the requestTimeout is already set.
How about the current change? Properties in `System` should have higher
priority. It can cover the requestTimeout if we set it passed by `-D`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
