szetszwo commented on code in PR #845:
URL: https://github.com/apache/ratis/pull/845#discussion_r1139879880
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderStateImpl.java:
##########
@@ -663,7 +663,7 @@ CompletableFuture<RaftClientReply>
submitStepDownRequestAsync(TransferLeadership
return pendingStepDown.submitAsync(request);
}
- private synchronized String sendStartLeaderElection(RaftPeerId follower,
TermIndex lastEntry) {
+ synchronized String sendStartLeaderElection(RaftPeerId follower, TermIndex
lastEntry) {
Review Comment:
Just found that `synchronized` is incorrect since it does not change
anything in `LeaderStateImpl`.
Actually, this method has nothing to do with `LeaderStateImpl`. Let move it
to `TransferLeadership` since it is used there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
