SzyWilliam commented on code in PR #913:
URL: https://github.com/apache/ratis/pull/913#discussion_r1315276236


##########
ratis-client/src/main/java/org/apache/ratis/client/impl/AsyncImpl.java:
##########
@@ -53,7 +53,7 @@ public CompletableFuture<RaftClientReply> 
sendReadOnly(Message message, RaftPeer
 
   @Override
   public CompletableFuture<RaftClientReply> sendReadAfterWrite(Message 
message) {
-    return send(RaftClientRequest.readAfterWriteConsistentRequestType(), 
message, null);
+    return 
UnorderedAsync.send(RaftClientRequest.readAfterWriteConsistentRequestType(), 
message, null, client);

Review Comment:
   You are right. Just investigated on `OrderedAsync` and `UnorderedAsync` and 
now I know why we should choose `OrderedAsync`. Thanks very much for your time 
spent and the detailed explanation! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to