szetszwo commented on code in PR #930:
URL: https://github.com/apache/ratis/pull/930#discussion_r1347665740
##########
ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java:
##########
@@ -88,6 +88,15 @@ default CompletableFuture<?> write(LogEntryProto entry) {
return CompletableFuture.completedFuture(null);
}
+ /**
+ * Write asynchronously the state machine data in the given log entry to
this state machine.
+ *
+ * @return a future for the write task
+ */
+ default CompletableFuture<?> write(LogEntryProto entry, TransactionContext
context) {
Review Comment:
That's a good point! Follower currently creates context in
`RaftServerImpl.applyLogToStateMachine`. We should create a context instead of
passing null and then the context can be reused. Let me think about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
