ivandika3 commented on code in PR #945:
URL: https://github.com/apache/ratis/pull/945#discussion_r1367890750
##########
ratis-common/src/main/java/org/apache/ratis/protocol/RoutingTable.java:
##########
@@ -159,7 +164,7 @@ public String toString() {
/** @return a new {@link RoutingTable} represented by the given map. */
static RoutingTable newRoutingTable(Map<RaftPeerId, Set<RaftPeerId>> map){
- Builder.validate(map);
+ RaftPeerId primary = Builder.validate(map);
Review Comment:
It seems this will trigger the `IllegalStateException` in
`RoutingTable#Builder#build` due to `newRoutingTable` returning `null`.
See failed CI:
https://github.com/ivandika3/ratis/actions/runs/6602996134/job/17935643444
Should I revert this and also re-add the check that
`routingTable.getPrimary() != null` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
