[ 
https://issues.apache.org/jira/browse/RATIS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782000#comment-17782000
 ] 

Tsz-wo Sze edited comment on RATIS-1562 at 11/2/23 5:46 AM:
------------------------------------------------------------

Thanks for filing this JIRA, which recall our discussion in 
https://github.com/apache/ratis/pull/832 .

The current code send only heartbeat but log entires  when installing 
snapshots.  We may improve by adding a 'probe' state, as suggested by [~William 
Song] in  [this 
comment|https://github.com/apache/ratis/pull/832#issuecomment-1451743645].


was (Author: szetszwo):
Thanks for filing this JIRA, which recall our discussion in 
https://github.com/apache/ratis/pull/832 .

The current code does not send appendEntires when installing snapshots.  We may 
improve by adding a 'probe' state, as suggested by [~William Song] in  [this 
comment|https://github.com/apache/ratis/pull/832#issuecomment-1451743645].

> Do not send AppendEntries while InstallSnapshot is in progress
> --------------------------------------------------------------
>
>                 Key: RATIS-1562
>                 URL: https://issues.apache.org/jira/browse/RATIS-1562
>             Project: Ratis
>          Issue Type: Improvement
>          Components: server
>            Reporter: Kaijie Chen
>            Priority: Major
>
> It is wasting of rpcs to send AppendEntries while InstallSnapshot is in 
> progress. Because the reply from the follower will always be INCONSISTENCY.
> See following design doc from etcd as a reference. Maybe we should also 
> introduce the follower progress state to Ratis.
> https://github.com/etcd-io/etcd/blob/main/raft/design.md



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to