wojiaodoubao commented on PR #954: URL: https://github.com/apache/ratis/pull/954#issuecomment-1791969529
In TestInstallSnapshotNotificationWithGrpc#testInstallSnapshotDuringBootstrap, the setConfiguration is separated into 2 rpc calls. Add peer s1 first, then peer s2. The s2 will be notified twice of install snapshot event. I think it doesn't break the semantic of notifyInstallSnapshot. Let me quote from GrpcLogAppender#shouldNotifyToInstallSnapshot. > Every follower should try to install at least one snapshot during bootstrapping, if available. The GrpcLogAppender keeps notifyInstallSnapshot to the bootstrapping follower again and again. So install snapshot twice does happen. Changing the assert condition to 2 <= numSnapshotRequests.get() should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
