szetszwo commented on code in PR #1112:
URL: https://github.com/apache/ratis/pull/1112#discussion_r1637251822
##########
dev-support/checks/unit.sh:
##########
@@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do
fi
if [[ ${ITERATIONS} -gt 1 ]]; then
+ if ! grep -q "Running .*Test" "${REPORT_DIR}/output.log"; then
Review Comment:
The pattern `"Running .*Test"` assume that the test name contains `Test`;
e.g.
```
$grep "Running .*Test"
~/Downloads/result-3-9475609402-split-16/iteration4/output.log
[INFO] Running org.apache.hadoop.fs.ozone.TestHSync
```
It may be better to grep `"Tests run: [1-9]"`.
```
$grep "Tests run: [1-9]"
~/Downloads/result-3-9475609402-split-16/iteration4/output.log
[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
154.095 s <<< FAILURE! - in org.apache.hadoop.fs.ozone.TestHSync
[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0
```
Then, it will work for any test names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ratis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
