szetszwo commented on code in PR #1140:
URL: https://github.com/apache/ratis/pull/1140#discussion_r1735530088
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -463,6 +465,13 @@ void groupRemove(boolean deleteDirectory, boolean
renameDirectory) {
/* Shutdown is triggered here inorder to avoid any locked files. */
state.getStateMachineUpdater().setRemoving();
close();
+ try {
+ closeFinishedLatch.await();
Review Comment:
The `CountDownLatch` may not help. When close() returns, it must past the
line `closeFinishedLatch.countDown();`. The new code seems the same as the
existing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ratis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
