szetszwo commented on code in PR #1142: URL: https://github.com/apache/ratis/pull/1142#discussion_r1742485611
########## ratis-server/src/main/java/org/apache/ratis/server/storage/SnapshotManager.java: ########## @@ -114,7 +115,8 @@ public void installSnapshot(InstallSnapshotRequestProto request, StateMachine st // TODO: Make sure that subsequent requests for the same installSnapshot are coming in order, // and are not lost when whole request cycle is done. Check requestId and requestIndex here - + MessageDigest digester = newMd5Digest(); + digester.reset(); Review Comment: I see. For an empty file, we probably need to handle it differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ratis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org