szetszwo commented on code in PR #1283:
URL: https://github.com/apache/ratis/pull/1283#discussion_r2347583755
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcServicesImpl.java:
##########
@@ -109,6 +109,7 @@ public static final class Builder {
private GrpcTlsConfig adminTlsConfig;
private String clientHost;
private int clientPort;
+ private int clientStubPoolSize;
Review Comment:
Let's call it `serverStubPoolSize` and move it right after `serverTlsConfig`.
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/GrpcConfigKeys.java:
##########
@@ -147,6 +147,15 @@ static void setPort(RaftProperties properties, int port) {
setInt(properties::setInt, PORT_KEY, port);
}
+ String STUB_POOL_SIZE_KEY = PREFIX + ".stub.pool.size";
+ int STUB_POOL_SIZE_DEFAULT = 10;
+ static int stubPoolSize(RaftProperties properties) {
+ return get(properties::getInt, STUB_POOL_SIZE_KEY,
STUB_POOL_SIZE_DEFAULT, getDefaultLog());
+ }
+ static void setStubPoolSize(RaftProperties properties, int size) {
+ setInt(properties::setInt, STUB_POOL_SIZE_KEY, size);
+ }
+
Review Comment:
This new conf should be under `GrpcConfigKeys.Server` since it is for the
server protocol. (`GrpcConfigKeys.Client` means client protocol.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
