slfan1989 commented on code in PR #1287:
URL: https://github.com/apache/ratis/pull/1287#discussion_r2365973032
##########
ratis-server/src/test/java/org/apache/ratis/statemachine/RaftSnapshotBaseTest.java:
##########
@@ -237,9 +227,8 @@ public void testBasicInstallSnapshot() throws Exception {
}
// add two more peers
- String[] newPeers = new String[]{"s3", "s4"};
- MiniRaftCluster.PeerChanges change = cluster.addNewPeers(
- newPeers, true, false);
+ final String[] newPeers = new String[]{"new0"};
Review Comment:
Thank you for the changes! I think it might be better if the new peer’s name
also starts with s, since that would be more consistent with the existing
naming. Also, the comment above should be updated accordingly.
##########
ratis-server/src/test/java/org/apache/ratis/statemachine/RaftSnapshotBaseTest.java:
##########
@@ -237,9 +227,8 @@ public void testBasicInstallSnapshot() throws Exception {
}
// add two more peers
- String[] newPeers = new String[]{"s3", "s4"};
- MiniRaftCluster.PeerChanges change = cluster.addNewPeers(
- newPeers, true, false);
+ final String[] newPeers = new String[]{"new0"};
Review Comment:
Thank you for the changes! I think it might be better if the new peer’s name
also starts with `s`, since that would be more consistent with the existing
naming. Also, the comment above should be updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
