leixm commented on PR #1285: URL: https://github.com/apache/ratis/pull/1285#issuecomment-3332528269
@szetszwo Thank you very much for your guidance. I have two questions to discuss: 1. ExceptionCaught is set to IOException, which doesn't cause a reconnection. Refer to IOUtils#shouldReconnect, but this may still cause issues. 2. https://github.com/apache/ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/NettyRpcProxy.java#L201, when a TimeoutException is caught, should we attempt to reconnect to avoid persistent timeouts in some exceptional cases? Can we add a new exception type, such as NettyRpcException, to wrap both of the above cases into a NettyRpcException, and then modify IOUtils#shouldReconnect to support reconnecting when a NettyRpcException is encountered? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
